krombel/oauth2
1
0
Fork 0
forked from remote/oauth2
Code Pull Requests 1 Activity

Update some nits

Browse Source 
Change-Id: I5164549afe6997f4512c9dc1954b97ca7a2c6c4d
This commit is contained in:
Patrick Jones
2021-01-11 11:26:11 -08:00
parent d16feb8435
commit 3bbb4361ee
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
google/internal/externalaccount/filecredsource.go
View File

@@ -9,6 +9,7 @@ import (
"encoding/json" "encoding/json"
"errors" "errors"
"fmt" "fmt"
"io"
"io/ioutil" "io/ioutil"
"os" "os"
) )
@@ -24,7 +25,7 @@ func (cs fileCredentialSource) subjectToken() (string, error) {
return "", fmt.Errorf("oauth2/google: failed to open credential file %q", cs.File) return "", fmt.Errorf("oauth2/google: failed to open credential file %q", cs.File)
} }
defer tokenFile.Close() defer tokenFile.Close()
tokenBytes, err := ioutil.ReadAll(tokenFile) tokenBytes, err := ioutil.ReadAll(io.LimitReader(tokenFile, 1<<20))
if err != nil { if err != nil {
return "", fmt.Errorf("oauth2/google: failed to read credential file: %v", err) return "", fmt.Errorf("oauth2/google: failed to read credential file: %v", err)
} }

2
google/internal/externalaccount/filecredsource_test.go
View File

@@ -55,7 +55,7 @@ func TestRetrieveFileSubjectToken(t *testing.T) {
out, err := tfc.parse().subjectToken() out, err := tfc.parse().subjectToken()
if err != nil { if err != nil {
t.Errorf("Method retrieveSubjectToken for type fileCredentialSource in test %v failed; %e", test.name, err) t.Fatalf("Method retrieveSubjectToken for type fileCredentialSource in test %v failed; %e", test.name, err)
} }
if out != test.want { if out != test.want {
t.Errorf("Test %v for method retrieveSubjectToken for type fileCredentialSouce failed: expected %v but got %v", test.name, test.want, out) t.Errorf("Test %v for method retrieveSubjectToken for type fileCredentialSouce failed: expected %v but got %v", test.name, test.want, out)