From 479e80d6a956e928512a86c0a57f2cabcd37f198 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Wed, 9 Mar 2022 11:04:13 -0800 Subject: [PATCH] fix: handle MainMenu.nib mismatch in Electron 18 (#42) --- src/index.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/index.ts b/src/index.ts index ebe4a71..cef9b58 100644 --- a/src/index.ts +++ b/src/index.ts @@ -115,6 +115,11 @@ export const makeUniversalApp = async (opts: MakeUniversalOpts): Promise = const arm64Sha = await sha(path.resolve(opts.arm64AppPath, file.relativePath)); if (x64Sha !== arm64Sha) { d('SHA for file', file.relativePath, `does not match across builds ${x64Sha}!=${arm64Sha}`); + // The MainMenu.nib files generated by Xcode13 are deterministic in effect but not deterministic in generated sequence + if (path.basename(path.dirname(file.relativePath)) === 'MainMenu.nib') { + // The mismatch here is OK so we just move on to the next one + continue; + } throw new Error( `Expected all non-binary files to have identical SHAs when creating a universal build but "${file.relativePath}" did not`, );